refactor(ruff): comply to ANN206, PLC0105, etc. #1445
Conversation
cmp0xff
changed the title
cmp0xff
changed the title
cmp0xff
force-pushed
the
feature/ruff-ann
branch
from
2dcb52f to
d8cb890
Compare
There was a problem hiding this comment.
Not really convinced about the value of forcing ANN on the tests files but fine since you already did the work.
@Dr-Irv let me know if you are onboard with the change of name for S2_CT to S2_contra and I will merge after.
The idea originated from #1405 (review). |
|
Thanks @cmp0xff |
| return super().astype(dtype, copy=copy) | ||
|
|
||
| def __setitem__(self, key, value) -> None: | ||
| def __setitem__(self, key: object, value: decimal._DecimalNew) -> None: |
There was a problem hiding this comment.
I think this is incorrect. It could be decimal._DecimalNew or list[decimal._DecimalNew]
If you do that, I think the ignores can be removed, and, if not, you can add assert isinstance(value, list)
Or it might need to be another type of Sequence
There was a problem hiding this comment.
ec57e21 it is hard, because Decimal can be constructed from both a scalar and from tuple[int, Sequence[int], int], which is an iterable itself.
* classify ann * mypy * fix(comment): #1445 (comment)
3 participants
*.pyiANN206,ANN401,PLC0105ANN401is permanently ignoredtests/*ANNexcept forANN401ANN401andARGare permanently ignoredKnown issue
tests/extension/decimal/array.py is a bit ugly now, hopefully it's okay. We can improve when we do typing for the arrays.